spi: ti-qspi: Use syscon_regmap_lookup_by_phandle_args

Use syscon_regmap_lookup_by_phandle_args() which is a wrapper over
syscon_regmap_lookup_by_phandle() combined with getting the syscon
argument.  Except simpler code this annotates within one line that given
phandle has arguments, so grepping for code would be easier.

There is also no real benefit in printing errors on missing syscon
argument, because this is done just too late: runtime check on
static/build-time data.  Dtschema and Devicetree bindings offer the
static/build-time check for this already.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://patch.msgid.link/20250111185400.183760-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/drivers/spi/spi-ti-qspi.c b/drivers/spi/spi-ti-qspi.c
index 49516fee74b0f2062c43d714fcb97c7a55580b37..a284d27945863b23819431b9d167fa9912c1a342 100644 (file)
--- a/drivers/spi/spi-ti-qspi.c
+++ b/drivers/spi/spi-ti-qspi.c
@@ -831,20 +831,12 @@ static int ti_qspi_probe(struct platform_device *pdev)
 
        if (of_property_present(np, "syscon-chipselects")) {
                qspi->ctrl_base =
-               syscon_regmap_lookup_by_phandle(np,
-                                               "syscon-chipselects");
+                       syscon_regmap_lookup_by_phandle_args(np, "syscon-chipselects",
+                                                            1, &qspi->ctrl_reg);
                if (IS_ERR(qspi->ctrl_base)) {
                        ret = PTR_ERR(qspi->ctrl_base);
                        goto free_host;
                }
-               ret = of_property_read_u32_index(np,
-                                                "syscon-chipselects",
-                                                1, &qspi->ctrl_reg);
-               if (ret) {
-                       dev_err(&pdev->dev,
-                               "couldn't get ctrl_mod reg index\n");
-                       goto free_host;
-               }
        }
 
        qspi->fclk = devm_clk_get(&pdev->dev, "fck");