phy: spear1340-miphy: Return proper error for spear1340_miphy_xlate
authorAxel Lin <axel.lin@ingics.com>
Wed, 1 Apr 2015 00:45:33 +0000 (08:45 +0800)
committerKishon Vijay Abraham I <kishon@ti.com>
Fri, 3 Apr 2015 12:46:21 +0000 (18:16 +0530)
The of_xlate callback should return ERR_PTR on error.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
drivers/phy/phy-spear1340-miphy.c

index e42bc200275f1e228813a8a26c7d4407bc3c9354..1a00c2817f34f8a7c5837ef8f701b09192702116 100644 (file)
@@ -229,14 +229,14 @@ static struct phy *spear1340_miphy_xlate(struct device *dev,
 
        if (args->args_count < 1) {
                dev_err(dev, "DT did not pass correct no of args\n");
-               return NULL;
+               return ERR_PTR(-ENODEV);
        }
 
        priv->mode = args->args[0];
 
        if (priv->mode != SATA && priv->mode != PCIE) {
                dev_err(dev, "DT did not pass correct phy mode\n");
-               return NULL;
+               return ERR_PTR(-ENODEV);
        }
 
        return priv->phy;