drm/amd/display: Use int for calculating vline start
authorHarry Wentland <harry.wentland@amd.com>
Tue, 10 Apr 2018 20:06:34 +0000 (16:06 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 15 May 2018 18:44:14 +0000 (13:44 -0500)
We are not sure these calculations will never need negative numbers. Use
signed integers and warn and cap at 0 if this ever happens.

Signed-off-by: Harry Wentland <harry.wentland@amd.com>
Reviewed-by: Tony Cheng <Tony.Cheng@amd.com>
Acked-by: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_optc.c

index 2c5dbece928e754ce81b68ae6aaa3204c418590c..c734b7fa58353816a445d1541bcbae515aa2bc4c 100644 (file)
@@ -96,10 +96,10 @@ static void optc1_disable_stereo(struct timing_generator *optc)
 static uint32_t get_start_vline(struct timing_generator *optc, const struct dc_crtc_timing *dc_crtc_timing)
 {
        struct dc_crtc_timing patched_crtc_timing;
-       uint32_t vesa_sync_start;
-       uint32_t asic_blank_end;
-       uint32_t interlace_factor;
-       uint32_t vertical_line_start;
+       int vesa_sync_start;
+       int asic_blank_end;
+       int interlace_factor;
+       int vertical_line_start;
 
        patched_crtc_timing = *dc_crtc_timing;
        optc1_apply_front_porch_workaround(optc, &patched_crtc_timing);