drm/rockchip: lvds: lower log severity for missing pinctrl settings
authorHeiko Stuebner <heiko.stuebner@cherry.de>
Tue, 4 Mar 2025 12:44:18 +0000 (13:44 +0100)
committerHeiko Stuebner <heiko@sntech.de>
Tue, 4 Mar 2025 15:59:58 +0000 (16:59 +0100)
While missing lvds pinctrl is unexpected and is reported, we nevertheless
don't fail setting up the device and instead continue without explicit
pinctrl handling. So lower the log-level from error to warning to reflect
that.

Suggested-by: Quentin Schulz <quentin.schulz@cherry.de>
Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de>
Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20250304124418.111061-4-heiko@sntech.de
drivers/gpu/drm/rockchip/rockchip_lvds.c

index bfebe42a03319358c1e61e90273b2e0f367f8ebd..a673779de3d2ebcc67eb9ee2d4ba98ebd537b8a4 100644 (file)
@@ -464,14 +464,14 @@ static int rk3288_lvds_probe(struct platform_device *pdev,
 
        lvds->pins->p = devm_pinctrl_get(lvds->dev);
        if (IS_ERR(lvds->pins->p)) {
-               dev_err(lvds->dev, "no pinctrl handle\n");
+               dev_warn(lvds->dev, "no pinctrl handle\n");
                devm_kfree(lvds->dev, lvds->pins);
                lvds->pins = NULL;
        } else {
                lvds->pins->default_state =
                        pinctrl_lookup_state(lvds->pins->p, "lcdc");
                if (IS_ERR(lvds->pins->default_state)) {
-                       dev_err(lvds->dev, "no default pinctrl state\n");
+                       dev_warn(lvds->dev, "no default pinctrl state\n");
                        devm_kfree(lvds->dev, lvds->pins);
                        lvds->pins = NULL;
                }