projects
/
linux-block.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
e2da021
)
net: ibm: emac: zmii: use devm for mutex_init
author
Rosen Penev
<rosenp@gmail.com>
Wed, 30 Oct 2024 20:37:23 +0000
(13:37 -0700)
committer
Jakub Kicinski
<kuba@kernel.org>
Sun, 3 Nov 2024 22:37:43 +0000
(14:37 -0800)
It seems that since inception, this driver never called mutex_destroy in
_remove. Use devm to handle this automatically.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Link:
https://patch.msgid.link/20241030203727.6039-9-rosenp@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/ibm/emac/zmii.c
patch
|
blob
|
blame
|
history
diff --git
a/drivers/net/ethernet/ibm/emac/zmii.c
b/drivers/net/ethernet/ibm/emac/zmii.c
index e9097b9ceb3dc906f637d6f344962e1416525d33..cb57c960b34d2fa6ed38d6a8e63f730bcac64792 100644
(file)
--- a/
drivers/net/ethernet/ibm/emac/zmii.c
+++ b/
drivers/net/ethernet/ibm/emac/zmii.c
@@
-235,13
+235,17
@@
static int zmii_probe(struct platform_device *ofdev)
struct device_node *np = ofdev->dev.of_node;
struct zmii_instance *dev;
struct resource regs;
+ int err;
dev = devm_kzalloc(&ofdev->dev, sizeof(struct zmii_instance),
GFP_KERNEL);
if (!dev)
return -ENOMEM;
- mutex_init(&dev->lock);
+ err = devm_mutex_init(&ofdev->dev, &dev->lock);
+ if (err)
+ return err;
+
dev->ofdev = ofdev;
dev->mode = PHY_INTERFACE_MODE_NA;