xfs: don't use bool values in trace buffers
authorChristoph Hellwig <hch@lst.de>
Fri, 21 Apr 2017 18:24:42 +0000 (11:24 -0700)
committerDarrick J. Wong <darrick.wong@oracle.com>
Tue, 25 Apr 2017 16:40:42 +0000 (09:40 -0700)
Using bool values produces sparse warnings of this form:

fs/xfs/./xfs_trace.h:2252:1: warning: odd constant _Bool cast (ffffffffffffffff becomes 1)
fs/xfs/./xfs_trace.h:2252:1: warning: odd constant _Bool cast (ffffffffffffffff becomes 1)
fs/xfs/./xfs_trace.h:2278:1: warning: odd constant _Bool cast (ffffffffffffffff becomes 1)
fs/xfs/./xfs_trace.h:2278:1: warning: odd constant _Bool cast (ffffffffffffffff becomes 1)
fs/xfs/./xfs_trace.h:2307:1: warning: odd constant _Bool cast (ffffffffffffffff becomes 1)

Just use a char instead to fix those up.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
fs/xfs/xfs_trace.h

index 09da3c18850bf634500d8888185ad73f71ea18a2..7c5a16528d8bb0506e999d2673404604c2b76920 100644 (file)
@@ -2255,8 +2255,8 @@ DECLARE_EVENT_CLASS(xfs_defer_class,
        TP_STRUCT__entry(
                __field(dev_t, dev)
                __field(void *, dop)
-               __field(bool, committed)
-               __field(bool, low)
+               __field(char, committed)
+               __field(char, low)
        ),
        TP_fast_assign(
                __entry->dev = mp ? mp->m_super->s_dev : 0;
@@ -2281,8 +2281,8 @@ DECLARE_EVENT_CLASS(xfs_defer_error_class,
        TP_STRUCT__entry(
                __field(dev_t, dev)
                __field(void *, dop)
-               __field(bool, committed)
-               __field(bool, low)
+               __field(char, committed)
+               __field(char, low)
                __field(int, error)
        ),
        TP_fast_assign(
@@ -2311,7 +2311,7 @@ DECLARE_EVENT_CLASS(xfs_defer_pending_class,
                __field(dev_t, dev)
                __field(int, type)
                __field(void *, intent)
-               __field(bool, committed)
+               __field(char, committed)
                __field(int, nr)
        ),
        TP_fast_assign(