drm/managed: Simplify if condition
authorThorsten Blum <thorsten.blum@toblux.com>
Mon, 1 Jul 2024 19:56:08 +0000 (21:56 +0200)
committerThomas Zimmermann <tzimmermann@suse.de>
Wed, 3 Jul 2024 08:11:03 +0000 (10:11 +0200)
The if condition !A || A && B can be simplified to !A || B.

Fixes the following Coccinelle/coccicheck warning reported by
excluded_middle.cocci:

WARNING !A || A && B is equivalent to !A || B

Compile-tested only.

Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20240701195607.228852-1-thorsten.blum@toblux.com
drivers/gpu/drm/drm_managed.c

index 7646f67bda4e47bf9f1a233e107d080f3e25770f..79ce86a5bd67a7201f5d60550a12364f2628e0ec 100644 (file)
@@ -197,7 +197,7 @@ void drmm_release_action(struct drm_device *dev,
        spin_lock_irqsave(&dev->managed.lock, flags);
        list_for_each_entry_reverse(dr, &dev->managed.resources, node.entry) {
                if (dr->node.release == action) {
-                       if (!data || (data && *(void **)dr->data == data)) {
+                       if (!data || *(void **)dr->data == data) {
                                dr_match = dr;
                                del_dr(dev, dr_match);
                                break;