projects
/
linux-block.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
f19d1e3
)
block: prevent an integer overflow in bvec_try_merge_hw_page
author
Christoph Hellwig
<hch@lst.de>
Mon, 4 Dec 2023 17:34:18 +0000
(18:34 +0100)
committer
Jens Axboe
<axboe@kernel.dk>
Fri, 15 Dec 2023 14:34:27 +0000
(07:34 -0700)
Reordered a check to avoid a possible overflow when adding len to bv_len.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Link:
https://lore.kernel.org/r/20231204173419.782378-2-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/bio.c
patch
|
blob
|
blame
|
history
diff --git
a/block/bio.c
b/block/bio.c
index 5eba53ca953b457b4fd979e4777e596238b2db19..270f6b99926eaa5b4f8866a95a360e135df58e51 100644
(file)
--- a/
block/bio.c
+++ b/
block/bio.c
@@
-944,7
+944,7
@@
bool bvec_try_merge_hw_page(struct request_queue *q, struct bio_vec *bv,
if ((addr1 | mask) != (addr2 | mask))
return false;
- if (
bv->bv_len + len > queue_max_segment_size(q)
)
+ if (
len > queue_max_segment_size(q) - bv->bv_len
)
return false;
return bvec_try_merge_page(bv, page, len, offset, same_page);
}