ALSA: usb-audio: scarlett2: Add temp variable for consistency
authorGeoffrey D. Bennett <g@b4.vu>
Sun, 20 Jun 2021 16:46:41 +0000 (02:16 +0930)
committerTakashi Iwai <tiwai@suse.de>
Mon, 21 Jun 2021 06:37:30 +0000 (08:37 +0200)
Add index temporary variable to scarlett2_mixer_ctl_put() for
consistency with the other *_ctl_put() functions.

Signed-off-by: Geoffrey D. Bennett <g@b4.vu>
Link: https://lore.kernel.org/r/20210620164641.GA9211@m.b4.vu
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/mixer_scarlett_gen2.c

index c1e74918425a7e67ab823aa1ec820fbc4a3b65c7..cb8483d3c58a929bdec613c0618308576cefccaf 100644 (file)
@@ -1622,18 +1622,19 @@ static int scarlett2_mixer_ctl_put(struct snd_kcontrol *kctl,
        const struct scarlett2_device_info *info = private->info;
        const struct scarlett2_ports *ports = info->ports;
        int oval, val, num_mixer_in, mix_num, err = 0;
+       int index = elem->control;
 
        mutex_lock(&private->data_mutex);
 
-       oval = private->mix[elem->control];
+       oval = private->mix[index];
        val = ucontrol->value.integer.value[0];
        num_mixer_in = ports[SCARLETT2_PORT_TYPE_MIX].num[SCARLETT2_PORT_OUT];
-       mix_num = elem->control / num_mixer_in;
+       mix_num = index / num_mixer_in;
 
        if (oval == val)
                goto unlock;
 
-       private->mix[elem->control] = val;
+       private->mix[index] = val;
        err = scarlett2_usb_set_mix(mixer, mix_num);
        if (err == 0)
                err = 1;