net: hns3: fix a bug in hns3_driv_to_eth_caps

The value of link_modes.advertising and the value of link_modes.supported
is initialized to zero every time in for loop in hns3_driv_to_eth_caps().
But we just want to set specified bit for them. Initialization is
unnecessary. This patch fixes it.

Fixes: 496d03e (net: hns3: Add Ethtool support to HNS3 driver)
Signed-off-by: Fuyun Liang <liangfuyun1@huawei.com>
Signed-off-by: Lipeng <lipeng321@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c
index 0e10a43e29b3d182ec69f0a8239eda97dec4ebb2..c7b8ebd14f3369a2bd634660603cae2a8facb7ab 100644 (file)
--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c
@@ -359,17 +359,12 @@ static void hns3_driv_to_eth_caps(u32 caps, struct ethtool_link_ksettings *cmd,
                if (!(caps & hns3_lm_map[i].hns3_link_mode))
                        continue;
 
-               if (is_advertised) {
-                       ethtool_link_ksettings_zero_link_mode(cmd,
-                                                             advertising);
+               if (is_advertised)
                        __set_bit(hns3_lm_map[i].ethtool_link_mode,
                                  cmd->link_modes.advertising);
-               } else {
-                       ethtool_link_ksettings_zero_link_mode(cmd,
-                                                             supported);
+               else
                        __set_bit(hns3_lm_map[i].ethtool_link_mode,
                                  cmd->link_modes.supported);
-               }
        }
 }