media: platform: mediatek: vpu: fix NULL ptr dereference

If pdev is NULL, then it is still dereferenced.

This fixes this smatch warning:

drivers/media/platform/mediatek/vpu/mtk_vpu.c:570 vpu_load_firmware() warn: address of NULL pointer 'pdev'

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: Yunfei Dong <yunfei.dong@mediatek.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

diff --git a/drivers/media/platform/mediatek/vpu/mtk_vpu.c b/drivers/media/platform/mediatek/vpu/mtk_vpu.c
index 5e2bc286f168ea030c7a266dc5cca2450718bc5e..1a95958a1f908595bdb5faa5eb7c3e1bc77df45f 100644 (file)
--- a/drivers/media/platform/mediatek/vpu/mtk_vpu.c
+++ b/drivers/media/platform/mediatek/vpu/mtk_vpu.c
@@ -562,15 +562,17 @@ static int load_requested_vpu(struct mtk_vpu *vpu,
 int vpu_load_firmware(struct platform_device *pdev)
 {
        struct mtk_vpu *vpu;
-       struct device *dev = &pdev->dev;
+       struct device *dev;
        struct vpu_run *run;
        int ret;
 
        if (!pdev) {
-               dev_err(dev, "VPU platform device is invalid\n");
+               pr_err("VPU platform device is invalid\n");
                return -EINVAL;
        }
 
+       dev = &pdev->dev;
+
        vpu = platform_get_drvdata(pdev);
        run = &vpu->run;