net: usb: lan78xx: remove explicit check for missing PHY driver
authorOleksij Rempel <o.rempel@pengutronix.de>
Mon, 5 May 2025 08:43:36 +0000 (10:43 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 7 May 2025 11:57:05 +0000 (12:57 +0100)
RGMII timing correctness relies on the PHY providing internal delays.
This is typically ensured via PHY driver, strap pins, or PCB layout.

Explicitly checking for a PHY driver here is unnecessary and non-standard.
This logic applies to all MACs, not just LAN78xx, and should be left to
phylib, phylink, or platform configuration.

Drop the check and rely on standard subsystem behavior.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Thangaraj Samynathan <thangaraj.s@microchip.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/lan78xx.c

index 19db18cf0504d5e1570080483811f6765b0e9936..9c0658227bde54e43e5d1e4afcf2240a8552df82 100644 (file)
@@ -2543,10 +2543,6 @@ static struct phy_device *lan7801_phy_init(struct lan78xx_net *dev)
                if (ret < 0)
                        return ERR_PTR(ret);
        } else {
-               if (!phydev->drv) {
-                       netdev_err(dev->net, "no PHY driver found\n");
-                       return ERR_PTR(-EINVAL);
-               }
                dev->interface = PHY_INTERFACE_MODE_RGMII_ID;
                /* The PHY driver is responsible to configure proper RGMII
                 * interface delays. Disable RGMII delays on MAC side.