tty: vt: use switch+case in the ESnonstd case
authorJiri Slaby (SUSE) <jirislaby@kernel.org>
Fri, 2 Feb 2024 06:56:05 +0000 (07:56 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 6 Feb 2024 14:37:39 +0000 (14:37 +0000)
To be uniform in the 'c' handling, use switch-case (with ranges) even in
the ESnonstd case in do_con_trol().

Signed-off-by: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Link: https://lore.kernel.org/r/20240202065608.14019-20-jirislaby@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/vt/vt.c

index b0f691d79bf26f7e2a16751c29ff3af1ba76286c..b5fc3b896e26f94943425b80112d0feb75a41bc9 100644 (file)
@@ -2573,17 +2573,19 @@ static void do_con_trol(struct tty_struct *tty, struct vc_data *vc, u8 c)
                handle_esc(tty, vc, c);
                return;
        case ESnonstd:  /* ESC ] aka OSC */
-               if (c=='P') {   /* palette escape sequence */
+               switch (c) {
+               case 'P': /* palette escape sequence */
                        vc_reset_params(vc);
                        vc->vc_state = ESpalette;
                        return;
-               } else if (c=='R') {   /* reset palette */
+               case 'R': /* reset palette */
                        reset_palette(vc);
-                       vc->vc_state = ESnormal;
-               } else if (c>='0' && c<='9')
+                       break;
+               case '0' ... '9':
                        vc->vc_state = ESosc;
-               else
-                       vc->vc_state = ESnormal;
+                       return;
+               }
+               vc->vc_state = ESnormal;
                return;
        case ESpalette: /* ESC ] P aka OSC P */
                if (isxdigit(c)) {