minixfs: Fix minixfs_rename with HIGHMEM
authorMatthew Wilcox (Oracle) <willy@infradead.org>
Tue, 9 Jul 2024 19:58:39 +0000 (20:58 +0100)
committerChristian Brauner <brauner@kernel.org>
Wed, 10 Jul 2024 05:15:36 +0000 (07:15 +0200)
minixfs now uses kmap_local_page(), so we can't call kunmap() to
undo it.  This one call was missed as part of the commit this fixes.

Fixes: 6628f69ee66a (minixfs: Use dir_put_page() in minix_unlink() and minix_rename())
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Link: https://lore.kernel.org/r/20240709195841.1986374-1-willy@infradead.org
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/minix/namei.c

index d6031acc34f0c50a5e09af237cbbfa387ae49853..a944a0f17b5371c240e1fc6bcc0b794d802f18d6 100644 (file)
@@ -213,8 +213,7 @@ static int minix_rename(struct mnt_idmap *idmap,
                if (!new_de)
                        goto out_dir;
                err = minix_set_link(new_de, new_page, old_inode);
-               kunmap(new_page);
-               put_page(new_page);
+               unmap_and_put_page(new_page, new_de);
                if (err)
                        goto out_dir;
                inode_set_ctime_current(new_inode);