drm/radeon: Remove unnecessary NULL values
authorRuan Jinjie <ruanjinjie@huawei.com>
Wed, 9 Aug 2023 03:44:42 +0000 (11:44 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 15 Aug 2023 22:08:27 +0000 (18:08 -0400)
The NULL initialization of the pointers assigned by kzalloc() first is
not necessary, because if the kzalloc() failed, the pointers will be
assigned NULL, otherwise it works as usual. so remove it.

Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/radeon/radeon_agp.c
drivers/gpu/drm/radeon/radeon_combios.c
drivers/gpu/drm/radeon/radeon_legacy_encoders.c

index d124600b5f58ebcdf593fd359116ac6f92a2f9d8..a3d749e350f9c231ccc7d105fd4b1a7d1d6a1afc 100644 (file)
@@ -130,7 +130,7 @@ static struct radeon_agpmode_quirk radeon_agpmode_quirk_list[] = {
 struct radeon_agp_head *radeon_agp_head_init(struct drm_device *dev)
 {
        struct pci_dev *pdev = to_pci_dev(dev->dev);
-       struct radeon_agp_head *head = NULL;
+       struct radeon_agp_head *head;
 
        head = kzalloc(sizeof(*head), GFP_KERNEL);
        if (!head)
index 795c3667f6d60a6b4759e8f5d9fd1eb4ab6a69dc..2620efc7c675bf9cb3e79729dfcfd124dfc954f0 100644 (file)
@@ -863,7 +863,7 @@ struct radeon_encoder_primary_dac *radeon_combios_get_primary_dac_info(struct
        struct radeon_device *rdev = dev->dev_private;
        uint16_t dac_info;
        uint8_t rev, bg, dac;
-       struct radeon_encoder_primary_dac *p_dac = NULL;
+       struct radeon_encoder_primary_dac *p_dac;
        int found = 0;
 
        p_dac = kzalloc(sizeof(struct radeon_encoder_primary_dac),
@@ -1014,7 +1014,7 @@ struct radeon_encoder_tv_dac *radeon_combios_get_tv_dac_info(struct
        struct radeon_device *rdev = dev->dev_private;
        uint16_t dac_info;
        uint8_t rev, bg, dac;
-       struct radeon_encoder_tv_dac *tv_dac = NULL;
+       struct radeon_encoder_tv_dac *tv_dac;
        int found = 0;
 
        tv_dac = kzalloc(sizeof(struct radeon_encoder_tv_dac), GFP_KERNEL);
@@ -1100,7 +1100,7 @@ static struct radeon_encoder_lvds *radeon_legacy_get_lvds_info_from_regs(struct
                                                                         radeon_device
                                                                         *rdev)
 {
-       struct radeon_encoder_lvds *lvds = NULL;
+       struct radeon_encoder_lvds *lvds;
        uint32_t fp_vert_stretch, fp_horz_stretch;
        uint32_t ppll_div_sel, ppll_val;
        uint32_t lvds_ss_gen_cntl = RREG32(RADEON_LVDS_SS_GEN_CNTL);
index 601d35d34eabfffbbf05d2f0e7a56b5f6d72e974..c4350ac2b3d27d059b79bb95d385d20f378b427e 100644 (file)
@@ -1692,7 +1692,7 @@ static struct radeon_encoder_int_tmds *radeon_legacy_get_tmds_info(struct radeon
 {
        struct drm_device *dev = encoder->base.dev;
        struct radeon_device *rdev = dev->dev_private;
-       struct radeon_encoder_int_tmds *tmds = NULL;
+       struct radeon_encoder_int_tmds *tmds;
        bool ret;
 
        tmds = kzalloc(sizeof(struct radeon_encoder_int_tmds), GFP_KERNEL);
@@ -1715,7 +1715,7 @@ static struct radeon_encoder_ext_tmds *radeon_legacy_get_ext_tmds_info(struct ra
 {
        struct drm_device *dev = encoder->base.dev;
        struct radeon_device *rdev = dev->dev_private;
-       struct radeon_encoder_ext_tmds *tmds = NULL;
+       struct radeon_encoder_ext_tmds *tmds;
        bool ret;
 
        if (rdev->is_atom_bios)