spi: sophgo: fix incorrect type for ret in sg2044_spifmc_write()
authorQasim Ijaz <qasdev00@gmail.com>
Thu, 13 Mar 2025 21:45:45 +0000 (21:45 +0000)
committerMark Brown <broonie@kernel.org>
Sun, 16 Mar 2025 23:34:24 +0000 (23:34 +0000)
The sg2044_spifmc_write() function uses 'ret' of unsigned type
size_t to capture return values from sg2044_spifmc_wait_xfer_size()
and sg2044_spifmc_wait_int(). Since these functions may return
negative error codes, using an unsigned type prevents proper
error detection, as size_t cannot represent negative values.

Change 'ret' to type int so that negative values are handled correctly.

Fixes: de16c322eefb ("spi: sophgo: add SG2044 SPI NOR controller driver")
Signed-off-by: Qasim Ijaz <qasdev00@gmail.com>
Link: https://patch.msgid.link/20250313214545.7444-1-qasdev00@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-sg2044-nor.c

index 454153a63b42e6c00687d39492bd8d7bfe643d21..baa4cf67766312fddf203d527f2b3821a38eb9e8 100644 (file)
@@ -216,7 +216,7 @@ static ssize_t sg2044_spifmc_write(struct sg2044_spifmc *spifmc,
        size_t xfer_size;
        const u8 *dout = op->data.buf.out;
        int i, offset;
-       size_t ret;
+       int ret;
        u32 reg;
 
        reg = sg2044_spifmc_init_reg(spifmc);