drm/xe: Only request PCODE_WRITE_MIN_FREQ_TABLE on LLC platforms
authorMatt Roper <matthew.d.roper@intel.com>
Mon, 10 Apr 2023 18:39:10 +0000 (11:39 -0700)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Tue, 19 Dec 2023 23:31:41 +0000 (18:31 -0500)
PCODE_WRITE_MIN_FREQ_TABLE is only applicable to platforms with an LLC.
Change the discrete GPU check to an LLC check instead; this take care of
skipping not only the discrete platforms, but also integrated platforms
like MTL that do not have an LLC.

Fixes MTL dmesg error:

  xe 0000:00:02.0: [drm] *ERROR* PCODE Mailbox failed: 1 Illegal Command

Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Link: https://lore.kernel.org/r/20230410183910.2696628-3-matthew.d.roper@intel.com
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/xe/xe_pcode.c

index fb1ce2d49bec5ea8bb4623b01766e01e52e5e421..99bb730684edc46001601ee86763e3eb4a61e75a 100644 (file)
@@ -210,7 +210,7 @@ int xe_pcode_init_min_freq_table(struct xe_gt *gt, u32 min_gt_freq,
        int ret;
        u32 freq;
 
-       if (IS_DGFX(gt_to_xe(gt)))
+       if (!gt_to_xe(gt)->info.has_llc)
                return 0;
 
        if (max_gt_freq <= min_gt_freq)