mm/page_alloc: drop the unnecessary pfn_valid() for start pfn
authorBaolin Wang <baolin.wang@linux.alibaba.com>
Mon, 24 Apr 2023 13:45:39 +0000 (21:45 +0800)
committerAndrew Morton <akpm@linux-foundation.org>
Fri, 9 Jun 2023 23:25:14 +0000 (16:25 -0700)
__pageblock_pfn_to_page() currently performs both pfn_valid check and
pfn_to_online_page().  The former one is redundant because the latter is a
stronger check.  Drop pfn_valid().

Link: https://lkml.kernel.org/r/c3868b58c6714c09a43440d7d02c7b4eed6e03f6.1682342634.git.baolin.wang@linux.alibaba.com
Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: "Huang, Ying" <ying.huang@intel.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Cc: Mel Gorman <mgorman@techsingularity.net>
Cc: Mike Rapoport (IBM) <rppt@kernel.org>
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/page_alloc.c

index 47421bedc12b7a99db2ac595f3e33fc20999aecf..af9c995d3c1e8d66023a9b20739a747e8aa08324 100644 (file)
@@ -1521,7 +1521,7 @@ struct page *__pageblock_pfn_to_page(unsigned long start_pfn,
        /* end_pfn is one past the range we are checking */
        end_pfn--;
 
-       if (!pfn_valid(start_pfn) || !pfn_valid(end_pfn))
+       if (!pfn_valid(end_pfn))
                return NULL;
 
        start_page = pfn_to_online_page(start_pfn);