ext4: Unwritten to written conversion requires EXT4_EX_NOCACHE
authorRitesh Harjani (IBM) <ritesh.list@gmail.com>
Mon, 19 May 2025 18:19:26 +0000 (23:49 +0530)
committerTheodore Ts'o <tytso@mit.edu>
Tue, 20 May 2025 18:21:00 +0000 (14:21 -0400)
This fixes the atomic write patch series after it was rebased on top of
extent status cache cleanup series i.e.

'commit 402e38e6b71f57 ("ext4: prevent stale extent cache entries caused by
concurrent I/O writeback")'

After the above series, EXT4_GET_BLOCKS_IO_CONVERT_EXT flag which has
EXT4_GET_BLOCKS_IO_SUBMIT flag set, requires that the io submit context
of any kind should pass EXT4_EX_NOCACHE to avoid caching unncecessary
extents in the extent status cache.

This patch fixes that by adding the EXT4_EX_NOCACHE flag in
ext4_convert_unwritten_extents_atomic() for unwritten to written
conversion calls to ext4_map_blocks().

Fixes: b86629c2b299 ("ext4: Add multi-fsblock atomic write support with bigalloc")
Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Reviewed-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
Link: https://patch.msgid.link/ea0ad9378ff6d31d73f4e53f87548e3a20817689.1747677758.git.ritesh.list@gmail.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/extents.c

index 74c16736ae34ec33ea80e3e549bea2cab0551da9..c1de66c23dd25638bbd707a45726190867e12d5a 100644 (file)
@@ -4827,7 +4827,7 @@ int ext4_convert_unwritten_extents_atomic(handle_t *handle, struct inode *inode,
        struct ext4_map_blocks map;
        unsigned int blkbits = inode->i_blkbits;
        unsigned int credits = 0;
-       int flags = EXT4_GET_BLOCKS_IO_CONVERT_EXT;
+       int flags = EXT4_GET_BLOCKS_IO_CONVERT_EXT | EXT4_EX_NOCACHE;
 
        map.m_lblk = offset >> blkbits;
        max_blocks = EXT4_MAX_BLOCKS(len, offset, blkbits);