ASoC: SOF: remove unused functions

hda_dsp_dump_skl() is never used and hda_dsp_get_status_skl() is
only called from that function. Remove both functions.

Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Keyon Jie <yang.jie@intel.com>
Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20210208232149.58899-4-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/sound/soc/sof/intel/hda.c b/sound/soc/sof/intel/hda.c
index 447163494b05fd1ad404579af6c0290efb6e721a..57853ef89cd1bd3fd95272981bd15ce7ee35dad2 100644 (file)
--- a/sound/soc/sof/intel/hda.c
+++ b/sound/soc/sof/intel/hda.c
@@ -317,26 +317,6 @@ static const struct hda_dsp_msg_code hda_dsp_rom_msg[] = {
        {HDA_DSP_ROM_NULL_FW_ENTRY,     "error: null FW entry point"},
 };
 
-static void hda_dsp_get_status_skl(struct snd_sof_dev *sdev)
-{
-       u32 status;
-       int i;
-
-       status = snd_sof_dsp_read(sdev, HDA_DSP_BAR,
-                                 HDA_ADSP_FW_STATUS_SKL);
-
-       for (i = 0; i < ARRAY_SIZE(hda_dsp_rom_msg); i++) {
-               if (status == hda_dsp_rom_msg[i].code) {
-                       dev_err(sdev->dev, "%s - code %8.8x\n",
-                               hda_dsp_rom_msg[i].msg, status);
-                       return;
-               }
-       }
-
-       /* not for us, must be generic sof message */
-       dev_dbg(sdev->dev, "unknown ROM status value %8.8x\n", status);
-}
-
 static void hda_dsp_get_status(struct snd_sof_dev *sdev)
 {
        u32 status;
@@ -385,36 +365,6 @@ static void hda_dsp_get_registers(struct snd_sof_dev *sdev,
                       stack_words * sizeof(u32));
 }
 
-void hda_dsp_dump_skl(struct snd_sof_dev *sdev, u32 flags)
-{
-       struct sof_ipc_dsp_oops_xtensa xoops;
-       struct sof_ipc_panic_info panic_info;
-       u32 stack[HDA_DSP_STACK_DUMP_SIZE];
-       u32 status, panic;
-
-       /* try APL specific status message types first */
-       hda_dsp_get_status_skl(sdev);
-
-       /* now try generic SOF status messages */
-       status = snd_sof_dsp_read(sdev, HDA_DSP_BAR,
-                                 HDA_ADSP_ERROR_CODE_SKL);
-
-       /*TODO: Check: there is no define in spec, but it is used in the code*/
-       panic = snd_sof_dsp_read(sdev, HDA_DSP_BAR,
-                                HDA_ADSP_ERROR_CODE_SKL + 0x4);
-
-       if (sdev->fw_state == SOF_FW_BOOT_COMPLETE) {
-               hda_dsp_get_registers(sdev, &xoops, &panic_info, stack,
-                                     HDA_DSP_STACK_DUMP_SIZE);
-               snd_sof_get_status(sdev, status, panic, &xoops, &panic_info,
-                                  stack, HDA_DSP_STACK_DUMP_SIZE);
-       } else {
-               dev_err(sdev->dev, "error: status = 0x%8.8x panic = 0x%8.8x\n",
-                       status, panic);
-               hda_dsp_get_status_skl(sdev);
-       }
-}
-
 /* dump the first 8 dwords representing the extended ROM status */
 static void hda_dsp_dump_ext_rom_status(struct snd_sof_dev *sdev, u32 flags)
 {

diff --git a/sound/soc/sof/intel/hda.h b/sound/soc/sof/intel/hda.h
index 8e39d1e16178d6d7f7d1db8375a4136c7e0740b8..d979411b404158c8b3cbe357ccda91a1d5860d72 100644 (file)
--- a/sound/soc/sof/intel/hda.h
+++ b/sound/soc/sof/intel/hda.h
@@ -517,7 +517,6 @@ int hda_dsp_runtime_suspend(struct snd_sof_dev *sdev);
 int hda_dsp_runtime_resume(struct snd_sof_dev *sdev);
 int hda_dsp_runtime_idle(struct snd_sof_dev *sdev);
 int hda_dsp_set_hw_params_upon_resume(struct snd_sof_dev *sdev);
-void hda_dsp_dump_skl(struct snd_sof_dev *sdev, u32 flags);
 void hda_dsp_dump(struct snd_sof_dev *sdev, u32 flags);
 void hda_ipc_dump(struct snd_sof_dev *sdev);
 void hda_ipc_irq_dump(struct snd_sof_dev *sdev);