blk-throttle: Eliminate redundant checks for data direction
authorTang Yizhou <yizhou.tang@shopee.com>
Tue, 23 Jan 2024 08:12:48 +0000 (16:12 +0800)
committerJens Axboe <axboe@kernel.dk>
Mon, 5 Feb 2024 17:16:12 +0000 (10:16 -0700)
After calling throtl_peek_queued(), the data direction can be determined so
there is no need to call bio_data_dir() to check the direction again.

Signed-off-by: Tang Yizhou <yizhou.tang@shopee.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20240123081248.3752878-1-yizhou.tang@shopee.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-throttle.c

index da9dc1f793c3b71a96a1e09e759adf39e91c71cb..f4850a6f860bbac8aba17aba9d217d83ec12f6a7 100644 (file)
@@ -1098,7 +1098,7 @@ static int throtl_dispatch_tg(struct throtl_grp *tg)
        while ((bio = throtl_peek_queued(&sq->queued[READ])) &&
               tg_may_dispatch(tg, bio, NULL)) {
 
-               tg_dispatch_one_bio(tg, bio_data_dir(bio));
+               tg_dispatch_one_bio(tg, READ);
                nr_reads++;
 
                if (nr_reads >= max_nr_reads)
@@ -1108,7 +1108,7 @@ static int throtl_dispatch_tg(struct throtl_grp *tg)
        while ((bio = throtl_peek_queued(&sq->queued[WRITE])) &&
               tg_may_dispatch(tg, bio, NULL)) {
 
-               tg_dispatch_one_bio(tg, bio_data_dir(bio));
+               tg_dispatch_one_bio(tg, WRITE);
                nr_writes++;
 
                if (nr_writes >= max_nr_writes)