net: dsa: mv88e6xxx: add field to specify internal phys layout

mv88e6xxx currently assumes that switch equipped with internal phys have
those phys mapped contiguously starting from port 0 (see
mv88e6xxx_phy_is_internal). However, some switches have internal PHYs but
NOT starting from port 0. For example 88e6393X, 88E6193X and 88E6191X have
integrated PHYs available on ports 1 to 8
To properly support this offset, add a new field to allow specifying an
internal PHYs layout. If field is not set, default layout is assumed (start
at port 0)

Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index 1b5a05f118b40a130ab28676357ff1b5a459bbd8..c967259fcadd6d1a5ee8da02250f28842e1021dd 100644 (file)
--- a/drivers/net/dsa/mv88e6xxx/chip.c
+++ b/drivers/net/dsa/mv88e6xxx/chip.c
@@ -465,7 +465,9 @@ restore_link:
 
 static int mv88e6xxx_phy_is_internal(struct mv88e6xxx_chip *chip, int port)
 {
-       return port < chip->info->num_internal_phys;
+       return port >= chip->info->internal_phys_offset &&
+               port < chip->info->num_internal_phys +
+                       chip->info->internal_phys_offset;
 }
 
 static int mv88e6xxx_port_ppu_updates(struct mv88e6xxx_chip *chip, int port)

diff --git a/drivers/net/dsa/mv88e6xxx/chip.h b/drivers/net/dsa/mv88e6xxx/chip.h
index da6e1339f809fc98924c06227bfc9fdf1b562c9a..eca51946c1008057e735d7153d9e6f1a7fc86c7a 100644 (file)
--- a/drivers/net/dsa/mv88e6xxx/chip.h
+++ b/drivers/net/dsa/mv88e6xxx/chip.h
@@ -167,6 +167,11 @@ struct mv88e6xxx_info {
 
        /* Supports PTP */
        bool ptp_support;
+
+       /* Internal PHY start index. 0 means that internal PHYs range starts at
+        * port 0, 1 means internal PHYs range starts at port 1, etc
+        */
+       unsigned int internal_phys_offset;
 };
 
 struct mv88e6xxx_atu_entry {

diff --git a/drivers/net/dsa/mv88e6xxx/global2.c b/drivers/net/dsa/mv88e6xxx/global2.c
index 61589689307682c6bf59bef040c3d438088228a8..937a01f2ba75ebe0e89e419da93a0b937352cb68 100644 (file)
--- a/drivers/net/dsa/mv88e6xxx/global2.c
+++ b/drivers/net/dsa/mv88e6xxx/global2.c
@@ -1196,9 +1196,12 @@ out:
 int mv88e6xxx_g2_irq_mdio_setup(struct mv88e6xxx_chip *chip,
                                struct mii_bus *bus)
 {
+       int phy_start = chip->info->internal_phys_offset;
+       int phy_end = chip->info->internal_phys_offset +
+                     chip->info->num_internal_phys;
        int phy, irq;
 
-       for (phy = 0; phy < chip->info->num_internal_phys; phy++) {
+       for (phy = phy_start; phy < phy_end; phy++) {
                irq = irq_find_mapping(chip->g2_irq.domain, phy);
                if (irq < 0)
                        return irq;