iio: magnetometer: mmc35240: make use of regmap_set_bits()
authorTrevor Gamblin <tgamblin@baylibre.com>
Mon, 17 Jun 2024 13:50:14 +0000 (09:50 -0400)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Tue, 25 Jun 2024 20:04:47 +0000 (21:04 +0100)
Instead of using regmap_update_bits() and passing the mask twice, use
regmap_set_bits().

Suggested-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Link: https://patch.msgid.link/20240617-review-v3-34-88d1338c4cca@baylibre.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/magnetometer/mmc35240.c

index c57932db455fabccf27cc84f6894546c53a7d1d1..dd480a4a5f98577242eb6d278758b8093638ccfe 100644 (file)
@@ -186,9 +186,8 @@ static int mmc35240_hw_set(struct mmc35240_data *data, bool set)
         * Recharge the capacitor at VCAP pin, requested to be issued
         * before a SET/RESET command.
         */
-       ret = regmap_update_bits(data->regmap, MMC35240_REG_CTRL0,
-                                MMC35240_CTRL0_REFILL_BIT,
-                                MMC35240_CTRL0_REFILL_BIT);
+       ret = regmap_set_bits(data->regmap, MMC35240_REG_CTRL0,
+                             MMC35240_CTRL0_REFILL_BIT);
        if (ret < 0)
                return ret;
        usleep_range(MMC35240_WAIT_CHARGE_PUMP, MMC35240_WAIT_CHARGE_PUMP + 1);
@@ -198,8 +197,7 @@ static int mmc35240_hw_set(struct mmc35240_data *data, bool set)
        else
                coil_bit = MMC35240_CTRL0_RESET_BIT;
 
-       return regmap_update_bits(data->regmap, MMC35240_REG_CTRL0,
-                                 coil_bit, coil_bit);
+       return regmap_set_bits(data->regmap, MMC35240_REG_CTRL0, coil_bit);
 
 }