staging: gpib: ines: struct gpib_interface
authorMichael Rubin <matchstick@neverthere.org>
Thu, 17 Apr 2025 00:32:41 +0000 (00:32 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 17 Apr 2025 09:12:54 +0000 (11:12 +0200)
Using Linux code style for struct gpib_interface.

Adhering to Linux code style.

Reported by checkpatch.pl

In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.

Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250417003246.84445-14-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/gpib/ines/ines_gpib.c

index 2d98c571a4b1f0625725f9b80efccfe9b5c923c1..bf830defcad34b07e117b9d2b3e9a2b1c1e31be4 100644 (file)
@@ -539,7 +539,7 @@ void ines_return_to_local(struct gpib_board *board)
        nec7210_return_to_local(board, &priv->nec7210_priv);
 }
 
-static gpib_interface_t ines_pci_unaccel_interface = {
+static struct gpib_interface ines_pci_unaccel_interface = {
        .name = "ines_pci_unaccel",
        .attach = ines_pci_attach,
        .detach = ines_pci_detach,
@@ -567,7 +567,7 @@ static gpib_interface_t ines_pci_unaccel_interface = {
        .return_to_local = ines_return_to_local,
 };
 
-static gpib_interface_t ines_pci_interface = {
+static struct gpib_interface ines_pci_interface = {
        .name = "ines_pci",
        .attach = ines_pci_accel_attach,
        .detach = ines_pci_detach,
@@ -595,7 +595,7 @@ static gpib_interface_t ines_pci_interface = {
        .return_to_local = ines_return_to_local,
 };
 
-static gpib_interface_t ines_pci_accel_interface = {
+static struct gpib_interface ines_pci_accel_interface = {
        .name = "ines_pci_accel",
        .attach = ines_pci_accel_attach,
        .detach = ines_pci_detach,
@@ -623,7 +623,7 @@ static gpib_interface_t ines_pci_accel_interface = {
        .return_to_local = ines_return_to_local,
 };
 
-static gpib_interface_t ines_isa_interface = {
+static struct gpib_interface ines_isa_interface = {
        .name = "ines_isa",
        .attach = ines_isa_attach,
        .detach = ines_isa_detach,
@@ -1218,7 +1218,7 @@ void ines_pcmcia_cleanup_module(void)
        pcmcia_unregister_driver(&ines_gpib_cs_driver);
 }
 
-static gpib_interface_t ines_pcmcia_unaccel_interface = {
+static struct gpib_interface ines_pcmcia_unaccel_interface = {
        .name = "ines_pcmcia_unaccel",
        .attach = ines_pcmcia_attach,
        .detach = ines_pcmcia_detach,
@@ -1246,7 +1246,7 @@ static gpib_interface_t ines_pcmcia_unaccel_interface = {
        .return_to_local = ines_return_to_local,
 };
 
-static gpib_interface_t ines_pcmcia_accel_interface = {
+static struct gpib_interface ines_pcmcia_accel_interface = {
        .name = "ines_pcmcia_accel",
        .attach = ines_pcmcia_accel_attach,
        .detach = ines_pcmcia_detach,
@@ -1274,7 +1274,7 @@ static gpib_interface_t ines_pcmcia_accel_interface = {
        .return_to_local = ines_return_to_local,
 };
 
-static gpib_interface_t ines_pcmcia_interface = {
+static struct gpib_interface ines_pcmcia_interface = {
        .name = "ines_pcmcia",
        .attach = ines_pcmcia_accel_attach,
        .detach = ines_pcmcia_detach,