signal: Replace memset(info,...) with clear_siginfo for clarity
authorEric W. Biederman <ebiederm@xmission.com>
Sat, 19 Aug 2017 00:56:27 +0000 (19:56 -0500)
committerEric W. Biederman <ebiederm@xmission.com>
Tue, 23 Jan 2018 01:07:08 +0000 (19:07 -0600)
The function clear_siginfo is just a nice wrapper around memset so
this results in no functional change.  This change makes mistakes
a little more difficult and it makes it clearer what is going on.

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
arch/um/kernel/trap.c
drivers/usb/core/devio.c
kernel/seccomp.c
kernel/time/posix-timers.c

index 428644175956231aad112a0ce221452913736635..b2b02df9896ee8ba629494bd4fa1c7551b26b178 100644 (file)
@@ -306,7 +306,7 @@ void relay_signal(int sig, struct siginfo *si, struct uml_pt_regs *regs)
 
        arch_examine_signal(sig, regs);
 
-       memset(&clean_si, 0, sizeof(clean_si));
+       clear_siginfo(&clean_si);
        clean_si.si_signo = si->si_signo;
        clean_si.si_errno = si->si_errno;
        clean_si.si_code = si->si_code;
index a3fad4ec9870d21e602fa80d8cf564fff5dd6d62..3f9bd3e4c3739b0c7377ef80ebcb31cc0c9492ac 100644 (file)
@@ -595,7 +595,7 @@ static void async_completed(struct urb *urb)
        as->status = urb->status;
        signr = as->signr;
        if (signr) {
-               memset(&sinfo, 0, sizeof(sinfo));
+               clear_siginfo(&sinfo);
                sinfo.si_signo = as->signr;
                sinfo.si_errno = as->status;
                sinfo.si_code = SI_ASYNCIO;
@@ -2613,7 +2613,7 @@ static void usbdev_remove(struct usb_device *udev)
                wake_up_all(&ps->wait);
                list_del_init(&ps->list);
                if (ps->discsignr) {
-                       memset(&sinfo, 0, sizeof(sinfo));
+                       clear_siginfo(&sinfo);
                        sinfo.si_signo = ps->discsignr;
                        sinfo.si_errno = EPIPE;
                        sinfo.si_code = SI_ASYNCIO;
index 5f0dfb2abb8d39542d72003f860e25eaff66c8f0..3153c9ea51bfb5b7bc28cb8773c5f24030df1556 100644 (file)
@@ -515,7 +515,7 @@ void put_seccomp_filter(struct task_struct *tsk)
 
 static void seccomp_init_siginfo(siginfo_t *info, int syscall, int reason)
 {
-       memset(info, 0, sizeof(*info));
+       clear_siginfo(info);
        info->si_signo = SIGSYS;
        info->si_code = SYS_SECCOMP;
        info->si_call_addr = (void __user *)KSTK_EIP(current);
index ec999f32c84058a0624d55ff3ee26a4fac63eb57..75043046914e593a567be64d3167bd2158bc1eb7 100644 (file)
@@ -462,7 +462,7 @@ static struct k_itimer * alloc_posix_timer(void)
                kmem_cache_free(posix_timers_cache, tmr);
                return NULL;
        }
-       memset(&tmr->sigq->info, 0, sizeof(siginfo_t));
+       clear_siginfo(&tmr->sigq->info);
        return tmr;
 }