ipv4: be friend with drop monitor
authorEric Dumazet <edumazet@google.com>
Sun, 19 Jan 2014 02:27:49 +0000 (18:27 -0800)
committerDavid S. Miller <davem@davemloft.net>
Sun, 19 Jan 2014 07:08:02 +0000 (23:08 -0800)
Replace some dev_kfree_skb() with kfree_skb() calls when
we drop one skb, this might help bug tracking.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/ip_gre.c
net/ipv4/ip_tunnel.c
net/ipv4/ip_vti.c
net/ipv4/ipip.c

index e560ef34cf4bd2efe9f1f7a64424441117a4502a..e7a92fdb36f61b779e04b1da45acf12312302c6b 100644 (file)
@@ -278,7 +278,7 @@ static netdev_tx_t ipgre_xmit(struct sk_buff *skb,
        return NETDEV_TX_OK;
 
 free_skb:
-       dev_kfree_skb(skb);
+       kfree_skb(skb);
 out:
        dev->stats.tx_dropped++;
        return NETDEV_TX_OK;
@@ -301,7 +301,7 @@ static netdev_tx_t gre_tap_xmit(struct sk_buff *skb,
        return NETDEV_TX_OK;
 
 free_skb:
-       dev_kfree_skb(skb);
+       kfree_skb(skb);
 out:
        dev->stats.tx_dropped++;
        return NETDEV_TX_OK;
index 432c28ab3197043895257710cae4a9c5138fcc09..83ede2e7ca42266ccdc3538f388819f6939879d2 100644 (file)
@@ -716,7 +716,7 @@ void ip_tunnel_xmit(struct sk_buff *skb, struct net_device *dev,
 
        if (skb_cow_head(skb, dev->needed_headroom)) {
                dev->stats.tx_dropped++;
-               dev_kfree_skb(skb);
+               kfree_skb(skb);
                return;
        }
 
@@ -732,7 +732,7 @@ tx_error_icmp:
 #endif
 tx_error:
        dev->stats.tx_errors++;
-       dev_kfree_skb(skb);
+       kfree_skb(skb);
 }
 EXPORT_SYMBOL_GPL(ip_tunnel_xmit);
 
index 0783200ad8d22af4ede97d3dcb6c0a2f184ee6ca..48eafae5176946841b53b95e7da8a46650fa548d 100644 (file)
@@ -162,7 +162,7 @@ tx_error_icmp:
        dst_link_failure(skb);
 tx_error:
        dev->stats.tx_errors++;
-       dev_kfree_skb(skb);
+       kfree_skb(skb);
        return NETDEV_TX_OK;
 }
 
index fe3e9f7f1f0beaf0ba6a8b7b4c788c8a021ba54d..812b1835146255fe065264dd236e901fe6937578 100644 (file)
@@ -228,7 +228,7 @@ static netdev_tx_t ipip_tunnel_xmit(struct sk_buff *skb, struct net_device *dev)
        return NETDEV_TX_OK;
 
 tx_error:
-       dev_kfree_skb(skb);
+       kfree_skb(skb);
 out:
        dev->stats.tx_errors++;
        return NETDEV_TX_OK;