drm/mcde: Fix uninitialized value
authorLinus Walleij <linus.walleij@linaro.org>
Thu, 19 Nov 2020 14:07:07 +0000 (15:07 +0100)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 23 Nov 2020 23:18:38 +0000 (00:18 +0100)
"val" isn't initialized on the default: errorpath.
Just return from the function if this happens.

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20201119140707.1008407-1-linus.walleij@linaro.org
drivers/gpu/drm/mcde/mcde_display.c

index 192e11c88d7296b5973efb0572ddbb79db4a4dc2..d941026b940c6cf9d4140dc5dd7f041da87e2d96 100644 (file)
@@ -569,7 +569,7 @@ static void mcde_configure_channel(struct mcde *mcde, enum mcde_channel ch,
        default:
                dev_err(mcde->dev, "unknown flow mode %d\n",
                        mcde->flow_mode);
-               break;
+               return;
        }
 
        writel(val, mcde->regs + sync);