net/mlx5: Remove newline at the end of a netlink error message
authorGal Pressman <gal@nvidia.com>
Wed, 26 Feb 2025 09:39:01 +0000 (11:39 +0200)
committerJakub Kicinski <kuba@kernel.org>
Fri, 28 Feb 2025 02:11:37 +0000 (18:11 -0800)
Netlink error messages should not have a newline at the end of the
string.

Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Signed-off-by: Gal Pressman <gal@nvidia.com>
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Link: https://patch.msgid.link/20250226093904.6632-3-gal@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlx5/core/dpll.c
drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_vxlan.c
drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c
drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c

index 31142f6cc3729375a7edbed5241179471c498243..1e5522a194839c44df72d7b4928b84bf244deecb 100644 (file)
@@ -242,7 +242,7 @@ static int mlx5_dpll_clock_quality_level_get(const struct dpll_device *dpll,
                return 0;
        }
 errout:
-       NL_SET_ERR_MSG_MOD(extack, "Invalid clock quality level obtained from firmware\n");
+       NL_SET_ERR_MSG_MOD(extack, "Invalid clock quality level obtained from firmware");
        return -EINVAL;
 }
 
index e4e487c8431b882e4282b4bfa94125b22cbddd04..5c762a71818db0c487f936262ded3f90f95f26b4 100644 (file)
@@ -140,7 +140,7 @@ static int mlx5e_tc_tun_parse_vxlan_gbp_option(struct mlx5e_priv *priv,
        gbp_mask = (u32 *)&enc_opts.mask->data[0];
 
        if (*gbp_mask & ~VXLAN_GBP_MASK) {
-               NL_SET_ERR_MSG_FMT_MOD(extack, "Wrong VxLAN GBP mask(0x%08X)\n", *gbp_mask);
+               NL_SET_ERR_MSG_FMT_MOD(extack, "Wrong VxLAN GBP mask(0x%08X)", *gbp_mask);
                return -EINVAL;
        }
 
index 0cb515fa179f5008ee94321e004ed82e502cfa82..3b2efde9dda24b8e65ee13580cd2b00448e45ecd 100644 (file)
@@ -2026,7 +2026,7 @@ static int mlx5e_get_module_eeprom_by_page(struct net_device *netdev,
                if (size_read < 0) {
                        NL_SET_ERR_MSG_FMT_MOD(
                                extack,
-                               "Query module eeprom by page failed, read %u bytes, err %d\n",
+                               "Query module eeprom by page failed, read %u bytes, err %d",
                                i, size_read);
                        return i;
                }
index 5f647358a05ca49698c998f2071d5a34a39a6928..76e35c827da000f5d7a108337ad2819a69d16cae 100644 (file)
@@ -1863,7 +1863,7 @@ int mlx5_esw_bridge_port_mdb_add(struct net_device *dev, u16 vport_num, u16 esw_
                         "Failed to lookup bridge port to add MDB (MAC=%pM,vport=%u)\n",
                         addr, vport_num);
                NL_SET_ERR_MSG_FMT_MOD(extack,
-                                      "Failed to lookup bridge port to add MDB (MAC=%pM,vport=%u)\n",
+                                      "Failed to lookup bridge port to add MDB (MAC=%pM,vport=%u)",
                                       addr, vport_num);
                return -EINVAL;
        }
@@ -1876,7 +1876,7 @@ int mlx5_esw_bridge_port_mdb_add(struct net_device *dev, u16 vport_num, u16 esw_
                                 "Failed to lookup bridge port vlan metadata to create MDB (MAC=%pM,vid=%u,vport=%u)\n",
                                 addr, vid, vport_num);
                        NL_SET_ERR_MSG_FMT_MOD(extack,
-                                              "Failed to lookup vlan metadata for MDB (MAC=%pM,vid=%u,vport=%u)\n",
+                                              "Failed to lookup vlan metadata for MDB (MAC=%pM,vid=%u,vport=%u)",
                                               addr, vid, vport_num);
                        return -EINVAL;
                }
@@ -1884,7 +1884,7 @@ int mlx5_esw_bridge_port_mdb_add(struct net_device *dev, u16 vport_num, u16 esw_
 
        err = mlx5_esw_bridge_port_mdb_attach(dev, port, addr, vid);
        if (err) {
-               NL_SET_ERR_MSG_FMT_MOD(extack, "Failed to add MDB (MAC=%pM,vid=%u,vport=%u)\n",
+               NL_SET_ERR_MSG_FMT_MOD(extack, "Failed to add MDB (MAC=%pM,vid=%u,vport=%u)",
                                       addr, vid, vport_num);
                return err;
        }