ieee802154: ca8210: Delete an error message for a failed memory allocation in ca8210_...
authorMarkus Elfring <elfring@users.sourceforge.net>
Mon, 22 May 2017 06:03:17 +0000 (08:03 +0200)
committerMarcel Holtmann <marcel@holtmann.org>
Mon, 22 May 2017 08:26:57 +0000 (10:26 +0200)
Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
drivers/net/ieee802154/ca8210.c

index 25ed11bb5ed36b49caf49c9bc3c4da9a31d5f0ac..f6df75e80a60a8dd619ab560490bec6745763a7f 100644 (file)
@@ -1808,10 +1808,9 @@ static int ca8210_skb_rx(
 
        /* Allocate mtu size buffer for every rx packet */
        skb = dev_alloc_skb(IEEE802154_MTU + sizeof(hdr));
-       if (!skb) {
-               dev_crit(&priv->spi->dev, "dev_alloc_skb failed\n");
+       if (!skb)
                return -ENOMEM;
-       }
+
        skb_reserve(skb, sizeof(hdr));
 
        msdulen = data_ind[22]; /* msdu_length */