OPP: ti: Fix ti_opp_supply_probe wrong return values
authorPrimoz Fiser <primoz.fiser@norik.com>
Thu, 6 Jun 2024 07:01:27 +0000 (09:01 +0200)
committerViresh Kumar <viresh.kumar@linaro.org>
Tue, 11 Jun 2024 05:28:48 +0000 (10:58 +0530)
Function ti_opp_supply_probe() since commit 6baee034cb55 ("OPP: ti:
Migrate to dev_pm_opp_set_config_regulators()") returns wrong values
when all goes well and hence driver probing eventually fails.

Fixes: 6baee034cb55 ("OPP: ti: Migrate to dev_pm_opp_set_config_regulators()")
Signed-off-by: Primoz Fiser <primoz.fiser@norik.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
drivers/opp/ti-opp-supply.c

index e3b97cd1fbbf3091c952b7a3b8c5178295ce21f8..ec0056a4bb135e642101c8ddb784d40f583ca27d 100644 (file)
@@ -393,10 +393,12 @@ static int ti_opp_supply_probe(struct platform_device *pdev)
        }
 
        ret = dev_pm_opp_set_config_regulators(cpu_dev, ti_opp_config_regulators);
-       if (ret < 0)
+       if (ret < 0) {
                _free_optimized_voltages(dev, &opp_data);
+               return ret;
+       }
 
-       return ret;
+       return 0;
 }
 
 static struct platform_driver ti_opp_supply_driver = {