projects
/
linux-block.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
b0b4a63
)
of: overlay: Fix missing of_node_put() in error case of init_overlay_changeset()
author
Kunihiko Hayashi
<hayashi.kunihiko@socionext.com>
Fri, 2 Jun 2023 02:05:02 +0000
(11:05 +0900)
committer
Rob Herring
<robh@kernel.org>
Fri, 9 Jun 2023 22:12:37 +0000
(16:12 -0600)
In init_overlay_changeset(), the variable "node" is from
of_get_child_by_name(), and the "node" should be discarded in error case.
Fixes:
d1651b03c2df
("of: overlay: add overlay symbols to live device tree")
Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Link:
https://lore.kernel.org/r/20230602020502.11693-1-hayashi.kunihiko@socionext.com
Signed-off-by: Rob Herring <robh@kernel.org>
drivers/of/overlay.c
patch
|
blob
|
blame
|
history
diff --git
a/drivers/of/overlay.c
b/drivers/of/overlay.c
index 2e01960f1aeb3e3f7695849bbff6cc4ce67ad4f9..7feb643f13707d34b4012e365c6011f18cb37373 100644
(file)
--- a/
drivers/of/overlay.c
+++ b/
drivers/of/overlay.c
@@
-811,6
+811,7
@@
static int init_overlay_changeset(struct overlay_changeset *ovcs)
if (!fragment->target) {
pr_err("symbols in overlay, but not in live tree\n");
ret = -EINVAL;
+ of_node_put(node);
goto err_out;
}