staging: vchiq_core: fix format strings in vchiq_dump_service_state
authorStefan Wahren <stefan.wahren@i2se.com>
Mon, 31 Oct 2016 14:39:28 +0000 (14:39 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 7 Nov 2016 10:05:47 +0000 (11:05 +0100)
The member localport and remoteport are unsigned. So fix the format
string accordingly.

The issue has been found by Cppcheck.

Signed-off-by: Stefam Wahren <stefan.wahren@i2se.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c

index 7984ff9fad87e3681b990425d44347001dc5c281..27738cadeb0abcd5615d125ee8435ca1ed366ca5 100644 (file)
@@ -3740,7 +3740,7 @@ vchiq_dump_service_state(void *dump_context, VCHIQ_SERVICE_T *service)
        char buf[80];
        int len;
 
-       len = snprintf(buf, sizeof(buf), "Service %d: %s (ref %u)",
+       len = snprintf(buf, sizeof(buf), "Service %u: %s (ref %u)",
                service->localport, srvstate_names[service->srvstate],
                service->ref_count - 1); /*Don't include the lock just taken*/
 
@@ -3752,7 +3752,7 @@ vchiq_dump_service_state(void *dump_context, VCHIQ_SERVICE_T *service)
                int tx_pending, rx_pending;
                if (service->remoteport != VCHIQ_PORT_FREE) {
                        int len2 = snprintf(remoteport, sizeof(remoteport),
-                               "%d", service->remoteport);
+                               "%u", service->remoteport);
                        if (service->public_fourcc != VCHIQ_FOURCC_INVALID)
                                snprintf(remoteport + len2,
                                        sizeof(remoteport) - len2,