thermal: rcar_thermal: Handle probe error gracefully
authorNiklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Tue, 10 Mar 2020 11:47:09 +0000 (12:47 +0100)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Fri, 20 Mar 2020 11:17:48 +0000 (12:17 +0100)
If the common register memory resource is not available the driver needs
to fail gracefully to disable PM. Instead of returning the error
directly store it in ret and use the already existing error path.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20200310114709.1483860-1-niklas.soderlund+renesas@ragnatech.se
drivers/thermal/rcar_thermal.c

index 8f1aafa2044e5ba797b0070febc414b5ec757432..4a48d1d2a31c92509140318b49bc7d65605179d9 100644 (file)
@@ -521,8 +521,10 @@ static int rcar_thermal_probe(struct platform_device *pdev)
                        res = platform_get_resource(pdev, IORESOURCE_MEM,
                                                    mres++);
                        common->base = devm_ioremap_resource(dev, res);
-                       if (IS_ERR(common->base))
-                               return PTR_ERR(common->base);
+                       if (IS_ERR(common->base)) {
+                               ret = PTR_ERR(common->base);
+                               goto error_unregister;
+                       }
 
                        idle = 0; /* polling delay is not needed */
                }