scsi: qla2xxx: Remove duplicate struct crb_addr_pair

In preparation for making the kmalloc family of allocators type aware, we
need to make sure that the returned type from the allocation matches the
type of the variable being assigned. (Before, the allocator would always
return "void *", which can be implicitly cast to any pointer type.)

The assigned type is "struct crb_addr_pair *" and the returned type will
be a _different_ "struct crb_addr_pair *", causing a warning. This really
stumped me for a bit. :) Drop the redundant declaration.

Signed-off-by: Kees Cook <kees@kernel.org>
Link: https://lore.kernel.org/r/20250426061951.work.272-kees@kernel.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/qla2xxx/qla_nx.c b/drivers/scsi/qla2xxx/qla_nx.c
index 78725bda3714f8b49246996dfeede87140f7470f..0cd3db8ed4ef9a69da74d8a35a4fe894ad8940b8 100644 (file)
--- a/drivers/scsi/qla2xxx/qla_nx.c
+++ b/drivers/scsi/qla2xxx/qla_nx.c
@@ -1099,11 +1099,6 @@ qla82xx_pinit_from_rom(scsi_qla_host_t *vha)
        unsigned offset, n;
        struct qla_hw_data *ha = vha->hw;
 
-       struct crb_addr_pair {
-               long addr;
-               long data;
-       };
-
        /* Halt all the individual PEGs and other blocks of the ISP */
        qla82xx_rom_lock(ha);