HID: intel-thc-hid: intel-quicki2c: pass correct arguments to acpi_evaluate_object
authorWentao Guan <guanwentao@uniontech.com>
Thu, 17 Apr 2025 13:50:23 +0000 (21:50 +0800)
committerJiri Kosina <jkosina@suse.com>
Thu, 24 Apr 2025 10:03:43 +0000 (12:03 +0200)
Delete unused argument, pass correct argument to acpi_evaluate_object.

Log:
  intel_quicki2c 0000:00:10.0: enabling device (0000 -> 0002)
  ACPI: \_SB.PC00.THC0.ICRS: 1 arguments were passed to a non-method ACPI object (Buffer) (20230628/nsarguments-211)
  ACPI: \_SB.PC00.THC0.ISUB: 1 arguments were passed to a non-method ACPI object (Buffer) (20230628/nsarguments-211)

Fixes: 5282e45ccbfa ("HID: intel-thc-hid: intel-quicki2c: Add THC QuickI2C ACPI interfaces")
Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
Signed-off-by: WangYuli <wangyuli@uniontech.com>
Reviewed-by: Even Xu <even.xu@intel.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c

index fa51155ebe3937b0d82d4d39a9971e7fb67d69b3..8a8c4a46f927009e49fc9c42db95ebe93959bd6c 100644 (file)
@@ -82,15 +82,10 @@ static int quicki2c_acpi_get_dsd_property(struct acpi_device *adev, acpi_string
 {
        acpi_handle handle = acpi_device_handle(adev);
        struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };
-       union acpi_object obj = { .type = type };
-       struct acpi_object_list arg_list = {
-               .count = 1,
-               .pointer = &obj,
-       };
        union acpi_object *ret_obj;
        acpi_status status;
 
-       status = acpi_evaluate_object(handle, dsd_method_name, &arg_list, &buffer);
+       status = acpi_evaluate_object(handle, dsd_method_name, NULL, &buffer);
        if (ACPI_FAILURE(status)) {
                acpi_handle_err(handle,
                                "Can't evaluate %s method: %d\n", dsd_method_name, status);