bcachefs: Fix locking in bch2_alloc_write_key()

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

diff --git a/fs/bcachefs/btree_gc.c b/fs/bcachefs/btree_gc.c
index 584aee7010deaa79df36edd60e5d7e59bcb7a7e3..bdaed29f084a4d558a160817e6fa6447c8547b0d 100644 (file)
--- a/fs/bcachefs/btree_gc.c
+++ b/fs/bcachefs/btree_gc.c
@@ -1392,11 +1392,11 @@ static int bch2_alloc_write_key(struct btree_trans *trans,
                                         *old,
                                         b->data_type);
        gc = *b;
-       percpu_up_read(&c->mark_lock);
 
        if (gc.data_type != old_gc.data_type ||
            gc.dirty_sectors != old_gc.dirty_sectors)
                bch2_dev_usage_update_m(c, ca, &old_gc, &gc);
+       percpu_up_read(&c->mark_lock);
 
        if (metadata_only &&
            gc.data_type != BCH_DATA_sb &&