projects
/
linux-2.6-block.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
016583d
)
NFS: silence a harmless uninitialized variable warning
author
Dan Carpenter
<dan.carpenter@oracle.com>
Thu, 12 Jul 2018 12:29:29 +0000
(15:29 +0300)
committer
Anna Schumaker
<Anna.Schumaker@Netapp.com>
Tue, 31 Jul 2018 16:53:40 +0000
(12:53 -0400)
kstrtoul() can return -ERANGE so Smatch complains that "num" can be
uninitialized. We check that it's within bounds so it's not a huge
deal.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
fs/nfs/super.c
patch
|
blob
|
blame
|
history
diff --git
a/fs/nfs/super.c
b/fs/nfs/super.c
index bdf39fa1bfbc738ceba92011e066a04f4318bc4c..ac4b2f005778c05df1bb68117f66fd407f20a529 100644
(file)
--- a/
fs/nfs/super.c
+++ b/
fs/nfs/super.c
@@
-2899,7
+2899,7
@@
static int param_set_portnr(const char *val, const struct kernel_param *kp)
if (!val)
return -EINVAL;
ret = kstrtoul(val, 0, &num);
- if (ret
== -EINVAL
|| num > NFS_CALLBACK_MAXPORTNR)
+ if (ret || num > NFS_CALLBACK_MAXPORTNR)
return -EINVAL;
*((unsigned int *)kp->arg) = num;
return 0;