mmc: sdhci-pltfm: move devm_ioremap_resource() up
authorMasahiro Yamada <yamada.masahiro@socionext.com>
Wed, 20 Apr 2016 02:16:30 +0000 (11:16 +0900)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 2 May 2016 08:33:34 +0000 (10:33 +0200)
Call devm_ioremap_resource() right after platform_get_resource().
This saves the error check of platform_get_resource() because
devm_ioremap_resource() checks if the given resource is NULL.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/sdhci-pltfm.c

index caa05d74a02cd2473be20b5cab4ddd3e69254d10..1d74db8374b4e80b86a757873b4de8537cb184ff 100644 (file)
@@ -119,11 +119,13 @@ struct sdhci_host *sdhci_pltfm_init(struct platform_device *pdev,
 {
        struct sdhci_host *host;
        struct resource *iomem;
+       void __iomem *ioaddr;
        int ret;
 
        iomem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       if (!iomem) {
-               ret = -ENOMEM;
+       ioaddr = devm_ioremap_resource(&pdev->dev, iomem);
+       if (IS_ERR(ioaddr)) {
+               ret = PTR_ERR(ioaddr);
                goto err;
        }
 
@@ -135,6 +137,7 @@ struct sdhci_host *sdhci_pltfm_init(struct platform_device *pdev,
                goto err;
        }
 
+       host->ioaddr = ioaddr;
        host->hw_name = dev_name(&pdev->dev);
        if (pdata && pdata->ops)
                host->ops = pdata->ops;
@@ -152,12 +155,6 @@ struct sdhci_host *sdhci_pltfm_init(struct platform_device *pdev,
                goto err_request;
        }
 
-       host->ioaddr = devm_ioremap_resource(&pdev->dev, iomem);
-       if (IS_ERR(host->ioaddr)) {
-               ret = PTR_ERR(host->ioaddr);
-               goto err_request;
-       }
-
        /*
         * Some platforms need to probe the controller to be able to
         * determine which caps should be used.