kasan: add kunit tests for kmalloc_track_caller, kmalloc_node_track_caller
authorNihar Chaithanya <niharchaithanya@gmail.com>
Mon, 14 Oct 2024 19:01:30 +0000 (00:31 +0530)
committerAndrew Morton <akpm@linux-foundation.org>
Tue, 12 Nov 2024 01:22:25 +0000 (17:22 -0800)
The Kunit tests for kmalloc_track_caller and kmalloc_node_track_caller
were missing in kasan_test_c.c, which check that these functions poison
the memory properly.

Add a Kunit test:
-> kmalloc_tracker_caller_oob_right(): This includes out-of-bounds
   access test for kmalloc_track_caller and kmalloc_node_track_caller.

Link: https://lkml.kernel.org/r/20241014190128.442059-1-niharchaithanya@gmail.com
Link: https://bugzilla.kernel.org/show_bug.cgi?id=216509
Signed-off-by: Nihar Chaithanya <niharchaithanya@gmail.com>
Reviewed-by: Andrey Konovalov <andreyknvl@gmail.com>
Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com>
Cc: Dmitry Vyukov <dvyukov@google.com>
Cc: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/kasan/kasan_test_c.c

index 000b996ff695b8d73be5e55abe36e783291cab56..e0ec5a6d15be134eea6361e85c236e5cf4bf9375 100644 (file)
@@ -215,6 +215,36 @@ static void kmalloc_node_oob_right(struct kunit *test)
        kfree(ptr);
 }
 
+static void kmalloc_track_caller_oob_right(struct kunit *test)
+{
+       char *ptr;
+       size_t size = 128 - KASAN_GRANULE_SIZE;
+
+       /*
+        * Check that KASAN detects out-of-bounds access for object allocated via
+        * kmalloc_track_caller().
+        */
+       ptr = kmalloc_track_caller(size, GFP_KERNEL);
+       KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ptr);
+
+       OPTIMIZER_HIDE_VAR(ptr);
+       KUNIT_EXPECT_KASAN_FAIL(test, ptr[size] = 'y');
+
+       kfree(ptr);
+
+       /*
+        * Check that KASAN detects out-of-bounds access for object allocated via
+        * kmalloc_node_track_caller().
+        */
+       ptr = kmalloc_node_track_caller(size, GFP_KERNEL, 0);
+       KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ptr);
+
+       OPTIMIZER_HIDE_VAR(ptr);
+       KUNIT_EXPECT_KASAN_FAIL(test, ptr[size] = 'y');
+
+       kfree(ptr);
+}
+
 /*
  * Check that KASAN detects an out-of-bounds access for a big object allocated
  * via kmalloc(). But not as big as to trigger the page_alloc fallback.
@@ -2015,6 +2045,7 @@ static struct kunit_case kasan_kunit_test_cases[] = {
        KUNIT_CASE(kmalloc_oob_right),
        KUNIT_CASE(kmalloc_oob_left),
        KUNIT_CASE(kmalloc_node_oob_right),
+       KUNIT_CASE(kmalloc_track_caller_oob_right),
        KUNIT_CASE(kmalloc_big_oob_right),
        KUNIT_CASE(kmalloc_large_oob_right),
        KUNIT_CASE(kmalloc_large_uaf),