iio: adc: stm32: Fixing err code to not indicate success
authorJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 30 Mar 2024 18:53:00 +0000 (18:53 +0000)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 13 Apr 2024 09:36:59 +0000 (10:36 +0100)
This path would result in returning 0 / success on an error path.

Cc: Olivier Moysan <olivier.moysan@foss.st.com>
Fixes: 95bc818404b2 ("iio: adc: stm32-adc: add support of generic channels binding")
Reviewed-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Link: https://lore.kernel.org/r/20240330185305.1319844-4-jic23@kernel.org
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/stm32-adc.c

index b5d3c9cea5c4e3a85f9470edc24bfd64e2b56784..283c2075710649814177b705a91d965a57ab390b 100644 (file)
@@ -2234,6 +2234,7 @@ static int stm32_adc_generic_chan_init(struct iio_dev *indio_dev,
                        if (vin[0] != val || vin[1] >= adc_info->max_channels) {
                                dev_err(&indio_dev->dev, "Invalid channel in%d-in%d\n",
                                        vin[0], vin[1]);
+                               ret = -EINVAL;
                                goto err;
                        }
                } else if (ret != -EINVAL) {