perf pmu-events: Remove aggr_mode from pmu_event
authorIan Rogers <irogers@google.com>
Sun, 19 Feb 2023 09:28:00 +0000 (01:28 -0800)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Sun, 19 Feb 2023 11:01:36 +0000 (08:01 -0300)
aggr_mode is used on Power to set a flag for metrics. For pmu_event it
is unused.

Signed-off-by: Ian Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: Andrii Nakryiko <andrii@kernel.org>
Cc: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Cc: Caleb Biggers <caleb.biggers@intel.com>
Cc: Eduard Zingerman <eddyz87@gmail.com>
Cc: Florian Fischer <florian.fischer@muhq.space>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: James Clark <james.clark@arm.com>
Cc: Jing Zhang <renyu.zj@linux.alibaba.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: John Garry <john.g.garry@oracle.com>
Cc: Kajol Jain <kjain@linux.ibm.com>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Leo Yan <leo.yan@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Perry Taylor <perry.taylor@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ravi Bangoria <ravi.bangoria@amd.com>
Cc: Sandipan Das <sandipan.das@amd.com>
Cc: Sean Christopherson <seanjc@google.com>
Cc: Stephane Eranian <eranian@google.com>
Cc: Suzuki Poulouse <suzuki.poulose@arm.com>
Cc: Xing Zhengjun <zhengjun.xing@linux.intel.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-stm32@st-md-mailman.stormreply.com
Link: https://lore.kernel.org/r/20230219092848.639226-4-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/pmu-events/jevents.py
tools/perf/pmu-events/pmu-events.h
tools/perf/tests/pmu-events.c

index 2bcd07ce609f4f1669b04dfe42c333ea47ea3fd7..db8b92de113e3381c411b6c2bc7ea1b814ffd01d 100755 (executable)
@@ -44,7 +44,7 @@ _json_event_attributes = [
     # Seems useful, put it early.
     'event',
     # Short things in alphabetical order.
-    'aggr_mode', 'compat', 'deprecated', 'perpkg', 'unit',
+    'compat', 'deprecated', 'perpkg', 'unit',
     # Longer things (the last won't be iterated over during decompress).
     'long_desc'
 ]
index b7d4a66b8ad2ce74335870fa1afa3c1bea66a5c2..cee8b83792f89916ce996812732189ec8b2b8839 100644 (file)
@@ -22,7 +22,6 @@ struct pmu_event {
        const char *pmu;
        const char *unit;
        const char *perpkg;
-       const char *aggr_mode;
        const char *deprecated;
 };
 
index accf44b3d968d8532edb8a8c118b5fabd28281b8..9b4c94ba54607a530f58ef5a5cfef184429dccab 100644 (file)
@@ -331,12 +331,6 @@ static int compare_pmu_events(const struct pmu_event *e1, const struct pmu_event
                return -1;
        }
 
-       if (!is_same(e1->aggr_mode, e2->aggr_mode)) {
-               pr_debug2("testing event e1 %s: mismatched aggr_mode, %s vs %s\n",
-                         e1->name, e1->aggr_mode, e2->aggr_mode);
-               return -1;
-       }
-
        if (!is_same(e1->deprecated, e2->deprecated)) {
                pr_debug2("testing event e1 %s: mismatched deprecated, %s vs %s\n",
                          e1->name, e1->deprecated, e2->deprecated);