PCI/AER: Reduce pci_print_aer() correctable error level to KERN_WARNING
authorKarolina Stolarek <karolina.stolarek@oracle.com>
Thu, 22 May 2025 23:21:20 +0000 (18:21 -0500)
committerBjorn Helgaas <bhelgaas@google.com>
Fri, 23 May 2025 16:02:19 +0000 (11:02 -0500)
Some existing logs in pci_print_aer() log with error severity by default.

Convert them to use KERN_WARNING for correctable errors and KERN_ERR for
uncorrectable errors.

[bhelgaas: commit log]

Signed-off-by: Karolina Stolarek <karolina.stolarek@oracle.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Tested-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Link: https://patch.msgid.link/20250522232339.1525671-15-helgaas@kernel.org
drivers/pci/pcie/aer.c

index f0936759ba8bfd7a7ee8c01c30ed77c0b46bfe4a..16779f281b2fa9498a92ec2d09b7dcd0fac72ec5 100644 (file)
@@ -787,14 +787,15 @@ void pci_print_aer(struct pci_dev *dev, int aer_severity,
        layer = AER_GET_LAYER_ERROR(aer_severity, status);
        agent = AER_GET_AGENT(aer_severity, status);
 
-       pci_err(dev, "aer_status: 0x%08x, aer_mask: 0x%08x\n", status, mask);
+       aer_printk(info.level, dev, "aer_status: 0x%08x, aer_mask: 0x%08x\n",
+                  status, mask);
        __aer_print_error(dev, &info);
-       pci_err(dev, "aer_layer=%s, aer_agent=%s\n",
-               aer_error_layer[layer], aer_agent_string[agent]);
+       aer_printk(info.level, dev, "aer_layer=%s, aer_agent=%s\n",
+                  aer_error_layer[layer], aer_agent_string[agent]);
 
        if (aer_severity != AER_CORRECTABLE)
-               pci_err(dev, "aer_uncor_severity: 0x%08x\n",
-                       aer->uncor_severity);
+               aer_printk(info.level, dev, "aer_uncor_severity: 0x%08x\n",
+                          aer->uncor_severity);
 
        if (tlp_header_valid)
                pcie_print_tlp_log(dev, &aer->header_log, info.level,