PM: runtime: Make clear what we do when conditions are wrong in rpm_suspend()

rpm_suspend() simple bails out when conditions are wrong. But this is not
immediately obvious from the code.  Make it clear what we do when conditions
are wrong in rpm_suspend().

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

diff --git a/drivers/base/power/runtime.c b/drivers/base/power/runtime.c
index 99c7da112c95c70557a79e0bf4825ca2c1b5e897..9f62790f644c5350f804c9b36dcb01748b64b2f6 100644 (file)
--- a/drivers/base/power/runtime.c
+++ b/drivers/base/power/runtime.c
@@ -523,13 +523,11 @@ static int rpm_suspend(struct device *dev, int rpmflags)
 
  repeat:
        retval = rpm_check_suspend_allowed(dev);
-
        if (retval < 0)
-               ;       /* Conditions are wrong. */
+               goto out;       /* Conditions are wrong. */
 
        /* Synchronous suspends are not allowed in the RPM_RESUMING state. */
-       else if (dev->power.runtime_status == RPM_RESUMING &&
-           !(rpmflags & RPM_ASYNC))
+       if (dev->power.runtime_status == RPM_RESUMING && !(rpmflags & RPM_ASYNC))
                retval = -EAGAIN;
        if (retval)
                goto out;