virtio_ring: remove unnecessary to_vvq call in vring hot path
authorXianting Tian <xianting.tian@linux.alibaba.com>
Mon, 28 Mar 2022 10:58:16 +0000 (18:58 +0800)
committerMichael S. Tsirkin <mst@redhat.com>
Tue, 31 May 2022 16:44:24 +0000 (12:44 -0400)
It passes '_vq' to virtqueue_use_indirect(), which still calls
to_vvq to get 'vq', let's directly pass 'vq'. It can avoid
unnecessary call of to_vvq in hot path.

Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
Message-Id: <20220328105817.1028065-1-xianting.tian@linux.alibaba.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
drivers/virtio/virtio_ring.c

index cfb028ca238ebf1fbcdc5b11b5870aa78956361a..f72d5ae2cd8fd72c84c8d56421073e9c6a28e060 100644 (file)
@@ -205,11 +205,9 @@ struct vring_virtqueue {
 
 #define to_vvq(_vq) container_of(_vq, struct vring_virtqueue, vq)
 
-static inline bool virtqueue_use_indirect(struct virtqueue *_vq,
+static inline bool virtqueue_use_indirect(struct vring_virtqueue *vq,
                                          unsigned int total_sg)
 {
-       struct vring_virtqueue *vq = to_vvq(_vq);
-
        /*
         * If the host supports indirect descriptor tables, and we have multiple
         * buffers, then go indirect. FIXME: tune this threshold
@@ -499,7 +497,7 @@ static inline int virtqueue_add_split(struct virtqueue *_vq,
 
        head = vq->free_head;
 
-       if (virtqueue_use_indirect(_vq, total_sg))
+       if (virtqueue_use_indirect(vq, total_sg))
                desc = alloc_indirect_split(_vq, total_sg, gfp);
        else {
                desc = NULL;
@@ -1178,7 +1176,7 @@ static inline int virtqueue_add_packed(struct virtqueue *_vq,
 
        BUG_ON(total_sg == 0);
 
-       if (virtqueue_use_indirect(_vq, total_sg)) {
+       if (virtqueue_use_indirect(vq, total_sg)) {
                err = virtqueue_add_indirect_packed(vq, sgs, total_sg, out_sgs,
                                                    in_sgs, data, gfp);
                if (err != -ENOMEM) {