phy: qcom: phy-qcom-snps-eusb2: Add support for eUSB2 repeater

For USB 2.0 compliance, eUSB2 needs a repeater. The PHY needs to
initialize and reset it. So add repeater support

Co-developed-by: Abel Vesa <abel.vesa@linaro.org>
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20230208190200.2966723-6-abel.vesa@linaro.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>

diff --git a/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c b/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c
index 64e835b7ef538b943827516bce98c74abf0aec59..eeaa1eb0e24be3411a688df8728798f397cec5e9 100644 (file)
--- a/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c
+++ b/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c
@@ -130,6 +130,8 @@ struct qcom_snps_eusb2_hsphy {
        struct regulator_bulk_data vregs[EUSB2_NUM_VREGS];
 
        enum phy_mode mode;
+
+       struct phy *repeater;
 };
 
 static int qcom_snps_eusb2_hsphy_set_mode(struct phy *p, enum phy_mode mode, int submode)
@@ -138,7 +140,7 @@ static int qcom_snps_eusb2_hsphy_set_mode(struct phy *p, enum phy_mode mode, int
 
        phy->mode = mode;
 
-       return 0;
+       return phy_set_mode_ext(phy->repeater, mode, submode);
 }
 
 static void qcom_snps_eusb2_hsphy_write_mask(void __iomem *base, u32 offset,
@@ -236,6 +238,12 @@ static int qcom_snps_eusb2_hsphy_init(struct phy *p)
        if (ret)
                return ret;
 
+       ret = phy_init(phy->repeater);
+       if (ret) {
+               dev_err(&p->dev, "repeater init failed. %d\n", ret);
+               goto disable_vreg;
+       }
+
        ret = clk_prepare_enable(phy->ref_clk);
        if (ret) {
                dev_err(&p->dev, "failed to enable ref clock, %d\n", ret);
@@ -343,6 +351,8 @@ static int qcom_snps_eusb2_hsphy_exit(struct phy *p)
 
        regulator_bulk_disable(ARRAY_SIZE(phy->vregs), phy->vregs);
 
+       phy_exit(phy->repeater);
+
        return 0;
 }
 
@@ -356,6 +366,7 @@ static const struct phy_ops qcom_snps_eusb2_hsphy_ops = {
 static int qcom_snps_eusb2_hsphy_probe(struct platform_device *pdev)
 {
        struct device *dev = &pdev->dev;
+       struct device_node *np = dev->of_node;
        struct qcom_snps_eusb2_hsphy *phy;
        struct phy_provider *phy_provider;
        struct phy *generic_phy;
@@ -387,6 +398,12 @@ static int qcom_snps_eusb2_hsphy_probe(struct platform_device *pdev)
        if (ret)
                return dev_err_probe(dev, ret,
                                     "failed to get regulator supplies\n");
+
+       phy->repeater = devm_of_phy_get_by_index(dev, np, 0);
+       if (IS_ERR(phy->repeater))
+               return dev_err_probe(dev, PTR_ERR(phy->repeater),
+                                    "failed to get repeater\n");
+
        generic_phy = devm_phy_create(dev, NULL, &qcom_snps_eusb2_hsphy_ops);
        if (IS_ERR(generic_phy)) {
                dev_err(dev, "failed to create phy %d\n", ret);