s390/mm: remove redundant check against VMEM_MAX_PHYS
authorAlexander Gordeev <agordeev@linux.ibm.com>
Sun, 2 Jul 2023 20:29:10 +0000 (22:29 +0200)
committerHeiko Carstens <hca@linux.ibm.com>
Mon, 24 Jul 2023 10:12:23 +0000 (12:12 +0200)
The value of ident_map_size could never exceed the value of
vmemmap as secured by setup_kernel_memory_layout() function:

/* make sure identity map doesn't overlay with vmemmap */
ident_map_size = min(ident_map_size, vmemmap_start);

Since VMEM_MAX_PHYS macro is set to vmemmap and a newly added
range is checked against ident_map_size in add_memory_merged()
function anyway, the check against VMEM_MAX_PHYS is redundant.

Reviewed-by: Heiko Carstens <hca@linux.ibm.com>
Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
drivers/s390/char/sclp_cmd.c

index 3c87057436d5419fdd26eab16fbf3f927abea4d4..8b4575a0db9fb77cff1e3f69f8ec58bf0ca19795 100644 (file)
@@ -392,10 +392,6 @@ static void __init add_memory_merged(u16 rn)
                goto skip_add;
        start = rn2addr(first_rn);
        size = (unsigned long long) num * sclp.rzm;
-       if (start >= VMEM_MAX_PHYS)
-               goto skip_add;
-       if (start + size > VMEM_MAX_PHYS)
-               size = VMEM_MAX_PHYS - start;
        if (start >= ident_map_size)
                goto skip_add;
        if (start + size > ident_map_size)