ARM: dts: at91: sama5d2 Xplained: Correct the macb irq pinctrl node
authorRomain Izard <romain.izard.pro@gmail.com>
Thu, 18 Feb 2016 10:21:06 +0000 (11:21 +0100)
committerNicolas Ferre <nicolas.ferre@atmel.com>
Tue, 1 Mar 2016 09:47:23 +0000 (10:47 +0100)
All pinctrl nodes for the Atmel pinctrl controller need to have their
bias configuration explicitly defined. Otherwise, the pinctrl mapping
is not valid.

It works for now as the pinctrl driver proceeds even with invalid
mappings, but this can become an issue, if the pinctrl driver starts
to require valid mappings. Additionally, the pin is not protected from
being remapped later by an other driver.

There is an external 1kOhms pull-up to 3.3V, so no bias is required on
the Ethernet PHY's interrupt line.

Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
Acked-by: Ludovic Desroches <ludovic.desroches@atmel.com>
Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
arch/arm/boot/dts/at91-sama5d2_xplained.dts

index e683856c507c8bedacb5f8746a43cf9e4aef2207..75341eec2dfd247df0e8bfa9c1d17bb6fbae040f 100644 (file)
 
                                pinctrl_macb0_phy_irq: macb0_phy_irq {
                                        pinmux = <PIN_PC9__GPIO>;
+                                       bias-disable;
                                };
 
                                pinctrl_pdmic_default: pdmic_default {