Revert "Bluetooth: btusb: Disable runtime suspend on Realtek devices"
authorAbhishek Pandit-Subedi <abhishekpandit@chromium.org>
Wed, 29 Jul 2020 23:17:43 +0000 (16:17 -0700)
committerMarcel Holtmann <marcel@holtmann.org>
Thu, 30 Jul 2020 09:55:10 +0000 (11:55 +0200)
This reverts commit 7ecacafc240638148567742cca41aa7144b4fe1e.

Testing this change on a board with RTL8822CE, I found that enabling
autosuspend has no effect on the stability of the system. The board
continued working after autosuspend, suspend and reboot.

The original commit makes it impossible to enable autosuspend on working
systems so it should be reverted. Disabling autosuspend should be done
via module param or udev in userspace instead.

Signed-off-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
Acked-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
drivers/bluetooth/btusb.c

index 1f51494f58181256d0dc9688880d97bee383dbec..8d2608ddfd08758f0037ce0c1f81cf6a7687aea6 100644 (file)
@@ -4086,10 +4086,6 @@ static int btusb_probe(struct usb_interface *intf,
                        set_bit(BTUSB_USE_ALT1_FOR_WBS, &data->flags);
                else
                        bt_dev_err(hdev, "Device does not support ALT setting 1");
-
-               err = usb_autopm_get_interface(intf);
-               if (err < 0)
-                       goto out_free_dev;
        }
 
        if (!reset)