HID: i2c-hid: switch to standard debugging APIs
authorThomas Weißschuh <linux@weissschuh.net>
Fri, 23 Dec 2022 02:53:34 +0000 (02:53 +0000)
committerJiri Kosina <jkosina@suse.cz>
Wed, 18 Jan 2023 08:40:53 +0000 (09:40 +0100)
Instead of implementing a custom form of dynamic debugging we can use
the standard debugging APIs. If the kernel is built with
CONFIG_DYNAMIC_DEBUG this will be more discoverable and featureful.

Also the previous module parameter "debug" is read-only so it can't
actually be enabled.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/i2c-hid/i2c-hid-core.c

index b86b62f971080b78259bebd057ec0697f305418f..b4ed21f256008650dfdc84c28e1ab87db91df109 100644 (file)
 #define I2C_HID_PWR_ON         0x00
 #define I2C_HID_PWR_SLEEP      0x01
 
-/* debug option */
-static bool debug;
-module_param(debug, bool, 0444);
-MODULE_PARM_DESC(debug, "print a lot of debug information");
-
-#define i2c_hid_dbg(ihid, fmt, arg...)                                   \
-do {                                                                     \
-       if (debug)                                                        \
-               dev_printk(KERN_DEBUG, &(ihid)->client->dev, fmt, ##arg); \
-} while (0)
+#define i2c_hid_dbg(ihid, ...) dev_dbg(&(ihid)->client->dev, __VA_ARGS__)
 
 struct i2c_hid_desc {
        __le16 wHIDDescLength;