staging: lustre: lov: lov_dev: remove unneeded null test before free
authorJulia Lawall <Julia.Lawall@lip6.fr>
Fri, 1 May 2015 19:37:57 +0000 (21:37 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 8 May 2015 07:23:53 +0000 (09:23 +0200)
Kfree can cope with a null argument, so drop null tests.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@ expression ptr; @@

- if (ptr != NULL)
  kfree(ptr);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/lustre/lustre/lov/lov_dev.c

index 63db87af7fe2054c1aa0bbc38c377220959d42a8..504b24a468fc13bbd614d52aed9040e09eb16033 100644 (file)
@@ -298,8 +298,7 @@ static struct lu_device *lov_device_free(const struct lu_env *env,
        const int         nr = ld->ld_target_nr;
 
        cl_device_fini(lu2cl_dev(d));
-       if (ld->ld_target != NULL)
-               kfree(ld->ld_target);
+       kfree(ld->ld_target);
        if (ld->ld_emrg != NULL)
                lov_emerg_free(ld->ld_emrg, nr);
        kfree(ld);